Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update leveldb dependency #350

Merged
merged 1 commit into from Aug 3, 2022

Conversation

mfmarche
Copy link
Contributor

@mfmarche mfmarche commented Aug 2, 2022

Update https://github.com/syndtr/goleveldb dependency

Fixes #349

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of the changes being introduced by the pull request:

Updates the dependency to https://github.com/syndtr/goleveldb. leveldb required an fsync after creation of the MANIFEST file.
Please verify and check that the pull request fulfills the following requirements:

  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@joshuagl
Copy link
Member

joshuagl commented Aug 3, 2022

Thank you for submitting this fix @mfmarche! The CI appears to be failing due to a missing entry in go.sum https://github.com/theupdateframework/go-tuf/runs/7641572216?check_suite_focus=true#step:6:27 would it be possible to address that?

Also, the DCO check failed. Could you git commit --signoff (or git commit -s) to include a signed-off-by entry in your commits? (You'll want to fix the existing commit before you add new ones to address the failing CI, you can do that with git commit --amend -s on the branch you used).

Update https://github.com/syndtr/goleveldb dependency

Fixes theupdateframework#349

Signed-off-by: Mike Marchetti <mike@agilicus.com>
@mfmarche
Copy link
Contributor Author

mfmarche commented Aug 3, 2022

hi @joshuagl thanks for the review. I made the changes and signed off. thank you.

Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again @mfmarche

@joshuagl
Copy link
Member

joshuagl commented Aug 3, 2022

Could someone give this a second +1? @znewman01 @asraa @mnm678

@znewman01 znewman01 merged commit 2b415d0 into theupdateframework:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update leveldb with fsync fix
3 participants