Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove typo in Alternate signing flow #344

Merged

Conversation

elfotografo007
Copy link
Contributor

Signed-off-by: Andrés Torres andrest@vmware.com

Please fill in the fields below to submit a pull request. The more information that is provided, the better.

Fixes #
Release Notes:

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of the changes being introduced by the pull request:
Remove typo in Alternate signing flow section of README. Running the current command was returning:

tuff add-signatures --signatures=root.json.sigs root.json
--signatures must not have an argument

With the suggestion, the command works as expected:

tuf add-signatures --signatures root.json.sigs root.json
tuf: added 1 new signature(s)

Please verify and check that the pull request fulfills the following requirements:

  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Signed-off-by: Andrés Torres <andrest@vmware.com>
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for taking the time to submit.

@trishankatdatadog trishankatdatadog merged commit 9020b3c into theupdateframework:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants