Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flakey util test #333

Merged
merged 1 commit into from Jun 30, 2022

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Jun 30, 2022

Signed-off-by: Asra Ali asraa@google.com

Please fill in the fields below to submit a pull request. The more information that is provided, the better.

Fixes #
Release Notes:

Types of changes:

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of the changes being introduced by the pull request:
This catches a flakey test, where maybe the erroneous sha512 was picked up before sha256.
For e.g. failed postsubmit here https://github.com/theupdateframework/go-tuf/runs/7137147768?check_suite_focus=true

Please verify and check that the pull request fulfills the following requirements:

  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@asraa asraa requested a review from joshuagl June 30, 2022 18:11
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa merged commit 0d40b25 into theupdateframework:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants