fix: verify length and hashes of fetched bytes before parsing #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuagl
changed the title
joshuagl
force-pushed
the
joshuagl/issue-233
branch
from
22abd01
to
0e78e98
Compare
mnm678
reviewed
Jun 22, 2022
mnm678
previously approved these changes
Jun 22, 2022
znewman01
previously approved these changes
Jun 22, 2022
rdimitrov
requested changes
Jun 23, 2022
Add BytesMatchLenAndHashes() to verify that fetched bytes match the expected length and hashes. This is useful to check data before parsing. Signed-off-by: Joshua Lock <jlock@vmware.com>
Signed-off-by: Joshua Lock <jlock@vmware.com>
Signed-off-by: Joshua Lock <jlock@vmware.com>
Signed-off-by: Joshua Lock <jlock@vmware.com>
We check the length and hashes of the fetched bytes before parsing them, therefore once the data are parsed into a FileMeta we only need to check against the expected version. The length and hashes checks are no longer required at this point, as they have already been done. Signed-off-by: Joshua Lock <jlock@vmware.com>
Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl
force-pushed
the
joshuagl/issue-233
branch
from
0e78e98
to
06b905d
Compare
Add tests for newly exported functions in the util package: * VersionEqual() - simple test of version number comparison * BytesMatchLenAndHashes() - check function returns appropriate errors when incorrect length, hashes, or both are passed Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl
force-pushed
the
joshuagl/issue-233
branch
from
06b905d
to
af46f5d
Compare
|
I've add some tests in af46f5d and removed the unnecessary PTAL @mnm678 @znewman01 @rdimitrov 🙏 |
mnm678
approved these changes
Jun 23, 2022
znewman01
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233
Release Notes:
Check hashes and length of downloaded snapshot and targets metadata before parsing.
Types of changes:
Description of the changes being introduced by the pull request:
Better match the specification by performing checks against length and hashes on the downloaded bytes before parsing the bytes into a FileMeta.
Please verify and check that the pull request fulfills the following requirements: