Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update go version to 1.18 #314

Merged
merged 3 commits into from Jun 10, 2022

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Jun 9, 2022

Signed-off-by: Asra Ali asraa@google.com

Please fill in the fields below to submit a pull request. The more information that is provided, the better.

Fixes #307
Release Notes:

Types of changes:

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of the changes being introduced by the pull request:
Updates go version to 1.18.

Do we want to continue to test previous go versions?

Please verify and check that the pull request fulfills the following requirements:

  • Tests have been added for the bug fix or new feature
  • [ x ] Docs have been added for the bug fix or new feature

Signed-off-by: Asra Ali <asraa@google.com>

fix

Signed-off-by: Asra Ali <asraa@google.com>
@asraa
Copy link
Contributor Author

asraa commented Jun 9, 2022

@rdimitrov does this address #301 with the content in TESTING.md? Mostly my incompatibility is due to python-tuf being at version .20. We should update that too

@asraa asraa changed the title code: update go version to 1.18 build: update go version to 1.18 Jun 9, 2022
@znewman01
Copy link
Contributor

Mostly my incompatibility is due to python-tuf being at version .20. We should update that too

#228 should do that (issue #221). It was blocked on #232, which #310 should fix. Once #310 is in I'll rebase

@asraa
Copy link
Contributor Author

asraa commented Jun 9, 2022

#228 should do that (issue #221). It was blocked on #232, which #310 should fix. Once #310 is in I'll rebase

Thank you! That's perf, closed that issue.

@rdimitrov
Copy link
Contributor

@rdimitrov does this address #301 with the content in TESTING.md? Mostly my incompatibility is due to python-tuf being at version .20. We should update that too

It does! Thank you! 🙏

rdimitrov
rdimitrov previously approved these changes Jun 10, 2022
znewman01
znewman01 previously approved these changes Jun 10, 2022
docs/TESTING.md Outdated Show resolved Hide resolved
Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa dismissed stale reviews from znewman01 and rdimitrov via 55eef1d June 10, 2022 13:51
Signed-off-by: Asra Ali <asraa@google.com>
@rdimitrov rdimitrov merged commit 36a2930 into theupdateframework:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code: bump the Go version of go-tuf from v1.16 to v1.18
3 participants