Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation with direct use of MkDocs #398

Merged
merged 1 commit into from Apr 17, 2022

Conversation

bbc2
Copy link
Collaborator

@bbc2 bbc2 commented Apr 17, 2022

Improvements:

Portray is great but I think we can do better by directly using MkDocs.

The new way to deploy the documentation is:

mkdocs gh-deploy

The result can currently temporarily be seen at https://bbc2.github.io/python-dotenv/.

@bbc2 bbc2 requested a review from theskumar April 17, 2022 10:48
@bbc2 bbc2 self-assigned this Apr 17, 2022
Improvements:

- Only the public API is documented
  - Thanks to `mkdocstrings` with `show_submodules: no`.
- Function parameter documentation is parsed and shown in tables.
- `None` paragraphs are removed.
  - This was reported at timothycrosley/pdocs#25
    but hasn't been merged.
- Footer layout is fixed.
  - It's currently broken with Portray, even on their own documentation
    (https://timothycrosley.github.io/portray/).
- Fix list levels in table of contents on home page.
  - Thanks to `mdx_truly_sane_lists`.
- Remove broken "edit" links.

Portray is great but I think we can do better by directly using MkDocs.

The new way to deploy the documentation is:

    mkdocs gh-deploy
@theskumar
Copy link
Owner

Portray is great but I think we can do better by directly using MkDocs.

Portray was meant to be easy to use and low maintenance. It seems it is not well maintained and introducing unwanted bottlenecks, also the project now needs more comprehensive docs, let's move forward with mkdocs.

While I think the current PR can be merged as-is. I would like to use the opportunity to document more improvements that this project can benefit from. We can address them as these as we go:

  1. Simplify the README so it consists of the summary and overview only. Detailed docs are then available via rendered mkdocs. The README is already getting too big now.
  2. Use github-actions to publish the docs from master branch.
  3. Add a developer guide or enhance the CONTRIBUTING.md to include the working with docs section.
  4. If possible get rid of symlinking the docs (Portray was primarily used for that reason).

@theskumar theskumar merged commit cb53e1e into theskumar:master Apr 17, 2022
@bbc2 bbc2 deleted the better-doc branch April 18, 2022 08:14
theskumar added a commit that referenced this pull request Jun 5, 2022
* master: (111 commits)
  chore: add how to run docs locally
  Improve documentation with direct use of MkDocs (#398)
  feat(cli): add support for execution via 'python -m' (#395)
  Use built-in unittest.mock instead of third-party mock
  Skip test_ipython if IPython is not available (#397)
  Docs: Improve documentation for variables without value (#390)
  Use `open` instead of `io.open`
  Fix link typo in changelog
  Release version 0.20.0
  Don't mark wheels as universal (#387)
  Fix installing entry points
  Add encoding parameter to {get,set,unset}_key
  chore: add test with Python 3.11 (#368)
  Release version 0.19.2
  Add missing trailing newline when adding new value
  Release version 0.19.1
  Add Python 3.10 support (#359)
  CHANGELOG.md: Fix typos discovered by codespell
  Release version 0.19.0
  Allow any text stream (`IO[str]`) as `stream`
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants