Add encoding parameter to {get,set,unset}_key #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter already exists for `dotenv_values` and `load_dotenv` and has the same meaning.
bbc2
force-pushed
the
encoding-param-for-get-set
branch
from
e2be8d6
to
e8ad6d8
Compare
|
This look great! |
|
How about adding and exposing this parameter to the cli as well? @bbc2 |
|
Good idea but I'll leave that for a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter already exists for
dotenv_valuesandload_dotenvand has the same meaning.Closes #378.