Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import error on Python 3.5.0 and 3.5.1 #267

Merged
merged 1 commit into from Jul 17, 2020
Merged

Fix import error on Python 3.5.0 and 3.5.1 #267

merged 1 commit into from Jul 17, 2020

Conversation

bbc2
Copy link
Collaborator

@bbc2 bbc2 commented Jul 16, 2020

While typing was added in 3.5.0, typing.Text was only added in
3.5.2, and so causes an AttributeError, not an ImportError
exception.

Replaces #262.

Closes #261.

@bbc2 bbc2 self-assigned this Jul 16, 2020
@bbc2
Fix import error on Python 3.5.0 and 3.5.1
c3d9c17 
While `typing` was added in 3.5.0, `typing.Text` was only added in
3.5.2, and so causes an `AttributeError`, not an `ImportError`
  exception.
@bbc2 bbc2 mentioned this pull request Jul 16, 2020
Closed
@coveralls
Copy link

coveralls commented Jul 16, 2020 •
edited

Coverage Status

Coverage remained the same at 89.855% when pulling c3d9c17 on bbc2:fix-import-error into 4b43436 on theskumar:master.

@gongqingkui gongqingkui mentioned this pull request Jul 17, 2020
Closed
@bbc2 bbc2 merged commit 78be0f8 into theskumar:master Jul 17, 2020
@bbc2 bbc2 deleted the fix-import-error branch July 17, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bbc2 bbc2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'typing' has no attribute 'Text'
2 participants
@bbc2 @coveralls