Fix empty expanded value for duplicate key #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example problematic file:
```bash
hello=hi
greetings=${hello}
goodbye=bye
greetings=${goodbye}
```
It would result in `greetings` being associated with the empty string
instead of `"bye"`.
The problem came from the fact that bindings were converted to a dict,
and so deduplicated by key, before being interpolated. The dict would
be `{"hello": "hi", "greetings": "${goodbye}", "goodbye": "bye"}` in the
earlier example, which shows why interpolation wouldn't work: `goodbye`
would not be defined when `greetings` was interpolated.
This commit fixes that by passing all values in order, even if there are
duplicated keys.
bbc2
force-pushed
the
fix-empty-expanded-value-duplicate-key
branch
from
1e99042
to
8ffd21c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example problematic file:
It would result in
greetingsbeing associated with the empty stringinstead of
"bye".The problem came from the fact that bindings were converted to a dict,
and so deduplicated by key, before being interpolated. The dict would
be
{"hello": "hi", "greetings": "${goodbye}", "goodbye": "bye"}in theearlier example, which shows why interpolation wouldn't work:
goodbyewould not be defined when
greetingswas interpolated.This commit fixes that by passing all values in order, even if there are
duplicated keys.
Closes #197