Fix handling of no-value and malformed lines #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bbc2
commented
Jan 17, 2020
bbc2
commented
- Don't print warning when key has no value.
- Reject more malformed lines (e.g. "A: B").
bbc2
force-pushed
the
fix-warning-malformed-lines
branch
from
acf3e7b
to
421fc0f
Compare
bbc2
force-pushed
the
fix-warning-malformed-lines
branch
from
421fc0f
to
22a71a1
Compare
|
@ulyssessouza I released 0.10.4 but then realized that it was printing "malformed line" warnings in the Docker Compose use case (key without value) and would accept some really malformed lines. Before I merge this and release 0.10.5, does this fix work for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.