-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make typing optional #179
Make typing optional #179
Conversation
5 similar comments
- Fall back to `collections.namedtuple` for `Binding` when typing is not present - Add import guards to all imports - Fixes theskumar#178 Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
d031087
to
7a90934
Compare
Is this change something you are willing to consider? It should be fairly straightforward to use this approach and it avoids the extra imports when not running under a type checker / in an editor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request. I left a few inline comments but I'm overall OK with the change.
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
- Fix local test failures Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
Sorry for taking so incredibly long to update this, real life happened and I wasn't able to do much open source work recently. Luckily I am able to catch back up and it looks like the updates since I worked on this were not very drastic, so I went ahead and caught back up with master and addressed / replied to the relevant comments. Let me know how you'd like to move forward! |
- Fall back to `collections.namedtuple` for `Binding` when typing is not present - Add import guards to all imports - Fixes theskumar#178 - Add missing coverage config to setup.cfg
collections.namedtuple
forBinding
when typing isnot present
Signed-off-by: Dan Ryan dan@danryan.co