Fix parsing of variable without a value #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python, `\s` also matches newlines. This would cause newlines to be
consumed by the equal sign matcher, resulting in the next line being
considered as a value.
For instance, the following would be parsed as `[("FOO", "BAR=b")]`
instead of [("FOO", ""), ("BAR", "b")].
```bash
FOO=
BAR=b
```
Fixes theskumar#157.
|
This Looks good to me. Thanks for the quick fix!! |
johnbergvall
pushed a commit
to johnbergvall/python-dotenv
that referenced
this pull request
Aug 13, 2021
In Python, `\s` also matches newlines. This would cause newlines to be
consumed by the equal sign matcher, resulting in the next line being
considered as a value.
For instance, the following would be parsed as `[("FOO", "BAR=b")]`
instead of [("FOO", ""), ("BAR", "b")].
```bash
FOO=
BAR=b
```
Fixes theskumar#157.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python,
\salso matches newlines. This would cause newlines to beconsumed by the equal sign matcher, resulting in the next line being
considered as a value.
For instance, the following would be parsed as
[("FOO", "BAR=b")]instead of
[("FOO", ""), ("BAR", "b")].Fixes #157.