Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple bus but one locator ? #27

Closed
tyx opened this issue Aug 19, 2016 · 5 comments
Closed

Multiple bus but one locator ? #27

tyx opened this issue Aug 19, 2016 · 5 comments

Comments

@tyx
Copy link
Contributor

tyx commented Aug 19, 2016

Hi guys,

I wanted to keep using this great tactician to manage also my queries in addition to my commands.

So I decided to create a second bus as specified in the doc but I just realized that the locator still unique. So I cannot attach a handler to a specific bus ? All the buses could handle all commands ? I'm not fan.

Does it bothers someone that I make a PR to change this behavior ?
The tag would evolve in something like

<tag name="tactician.handler" bus="default" command="My\Command" />

We could also attach by default (no bus attribute specified) to all locators to keep BC if someone currently use same command through different buses.

Let me know if I miss something.

@tyx tyx changed the title Mulitple bus but one locator ? Multiple bus but one locator ? Aug 19, 2016
@rosstuck
Copy link
Member

Sounds pretty reasonable to me. :)

@tyx
Copy link
Contributor Author

tyx commented Aug 22, 2016

Great. Currently on holidays I will have a try when I will be back.

@rosstuck
Copy link
Member

On a related note, I got a request yesterday to be able to set an inflector per bus as well. Perhaps we should rejigger the build/config system a bit in general?

But for now, ignore that and enjoy a well deserved holiday! 😄

@tyx
Copy link
Contributor Author

tyx commented Sep 27, 2016

I will start to work on it.

an inflector per bus as well

Same here, we need it !

@tyx
Copy link
Contributor Author

tyx commented Sep 27, 2016

Let's go on #29

@tyx tyx closed this as completed Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants