From c85a4f316efff2477ad04fb3d9b2c8b121d3d049 Mon Sep 17 00:00:00 2001 From: pkowalczyk <11366345+PabloKowalczyk@users.noreply.github.com> Date: Sat, 15 Dec 2018 11:11:03 +0100 Subject: [PATCH 1/5] Fix Symfony 4.2 deprecation --- src/DependencyInjection/Configuration.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php index f2fe99d..ad1ad3d 100644 --- a/src/DependencyInjection/Configuration.php +++ b/src/DependencyInjection/Configuration.php @@ -21,8 +21,14 @@ class Configuration implements ConfigurationInterface */ public function getConfigTreeBuilder() { - $treeBuilder = new TreeBuilder(); - $rootNode = $treeBuilder->root('tactician'); + $treeBuilder = new TreeBuilder('tactician'); + + if (\method_exists($treeBuilder, 'getRootNode')) { + $rootNode = $treeBuilder->getRootNode(); + } else { + // BC layer for symfony/config 4.1 and older + $rootNode = $treeBuilder->root('tactician'); + } $rootNode ->children() From ae2e0960712875c82f2ce3e6189ec123b34f5f39 Mon Sep 17 00:00:00 2001 From: pkowalczyk <11366345+PabloKowalczyk@users.noreply.github.com> Date: Sat, 15 Dec 2018 11:12:07 +0100 Subject: [PATCH 2/5] Run CI with PHP 7.3 and nightly also --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index d202314..8d36031 100644 --- a/.travis.yml +++ b/.travis.yml @@ -10,6 +10,8 @@ php: - 7.0 - 7.1 - 7.2 + - 7.3 + - nightly env: matrix: From b73a879530f388095bfef28ceae5ec24853f7e5f Mon Sep 17 00:00:00 2001 From: pkowalczyk <11366345+PabloKowalczyk@users.noreply.github.com> Date: Sat, 15 Dec 2018 11:12:27 +0100 Subject: [PATCH 3/5] Test also against Symfony 4.1 and 4.2 --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index 8d36031..d0ef2e3 100644 --- a/.travis.yml +++ b/.travis.yml @@ -21,6 +21,8 @@ env: - SYMFONY_VERSION="3.3.*" - SYMFONY_VERSION="3.4.*" - SYMFONY_VERSION="4.0.*" + - SYMFONY_VERSION="4.1.*" + - SYMFONY_VERSION="4.2.*" matrix: include: From 613743095a5f1adb99dcac21d480e70096e26f92 Mon Sep 17 00:00:00 2001 From: pkowalczyk <11366345+PabloKowalczyk@users.noreply.github.com> Date: Sat, 15 Dec 2018 11:21:31 +0100 Subject: [PATCH 4/5] Exclude not supported test cases --- .travis.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index d0ef2e3..f898488 100644 --- a/.travis.yml +++ b/.travis.yml @@ -33,7 +33,10 @@ matrix: exclude: - php: 7.0 env: SYMFONY_VERSION="4.0.*" - + - php: 7.0 + env: SYMFONY_VERSION="4.1.*" + - php: 7.0 + env: SYMFONY_VERSION="4.2.*" before_install: - composer self-update || true From 002482c26a72f81ef0120bf461f9712ba8f3d8c5 Mon Sep 17 00:00:00 2001 From: pkowalczyk <11366345+PabloKowalczyk@users.noreply.github.com> Date: Sat, 15 Dec 2018 12:58:39 +0100 Subject: [PATCH 5/5] Reduce Symfony's logger verbosity --- phpunit.xml.dist | 3 +++ 1 file changed, 3 insertions(+) diff --git a/phpunit.xml.dist b/phpunit.xml.dist index 6010f11..e759330 100644 --- a/phpunit.xml.dist +++ b/phpunit.xml.dist @@ -19,6 +19,9 @@ tests/Integration + + + src/