Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using undefined use statements #202

Open
w00tland opened this issue Feb 15, 2019 · 1 comment
Open

Using undefined use statements #202

w00tland opened this issue Feb 15, 2019 · 1 comment

Comments

@w00tland
Copy link

w00tland commented Feb 15, 2019

I see omnipay-common is using some use statements to undefined classes in Omnipay\Common\Http\Client;

use Http\Client\HttpClient;
use Http\Discovery\HttpClientDiscovery;
use Http\Discovery\MessageFactoryDiscovery;
use Http\Message\RequestFactory;

There are no such files in the Http folder. Am I missing something here?

@judgej
Copy link
Member

judgej commented Feb 25, 2019

Some of those are used:

https://github.com/thephpleague/omnipay-common/blob/master/src/Common/Http/Client.php#L35

But if you want to create a PR, then that could be merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants