Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fetching of extraMetadata #1323

Open
timwsuqld opened this issue Jun 22, 2021 · 4 comments · May be fixed by #1324
Open

Allow fetching of extraMetadata #1323

timwsuqld opened this issue Jun 22, 2021 · 4 comments · May be fixed by #1324

Comments

@timwsuqld
Copy link

Feature Request

Q A
New Feature yes
BC Break yes

Scenario / Use-case

Many backends provide more metadata. We currently populate FileAttributes with the data, but don't provide a way to access it. While we can't provide interfaces into any of that data in a way that would allow cross adapter use, we can just provide that data. That way when using the Flysystem, if you either know the specific filesystem adapter that will be used, or can use the metadata with a fallback, you can make for a more efficient system. For example, a few systems return the md5sum in the metadata, this can be used to check if a file matches an existing file before updating the file. It's easy enough to check the returned metadata for that field, and if not present, then code a fallback method (it may be more costly to replace the file if it hasn't changed).

I believe this would be a BC due to the addition of methods to the interfaces.

Summary

Expose the extraMetadata attribute to the end user.

@timwsuqld timwsuqld linked a pull request Jun 22, 2021 that will close this issue
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 2, 2022
@PaolaRuby
Copy link
Contributor

this would have been nice in v3

@stale stale bot removed the stale label Mar 2, 2022
@neffets
Copy link

neffets commented Apr 25, 2022

I have use of this feature too.
I want provide further meta-data for attribution and licenses in the extraMetadata

@marden
Copy link

marden commented Jan 23, 2023

It's definitely a high-value feature, especially for S3 as it holds a lot of useful metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants