Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding attributes without value #986

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Allow adding attributes without value #986

merged 5 commits into from
Jul 31, 2023

Conversation

svenluijten
Copy link
Contributor

As said in #985, this is my attempt at allowing valueless attributes to be set on elements.

@svenluijten
Copy link
Contributor Author

svenluijten commented Jul 29, 2023 •
edited

Unfortunately the tests seem to fail as it is, probably because the regex is now too loose, causing a single functional test to fail; one that has to do with illegal whitespace in HTML. I'd appreciate some help to fix that if this is a feature you'd want included 🙂

@colinodell colinodell linked an issue Jul 31, 2023 that may be closed by this pull request
Allow setting attributes without values in Attributes extension #985
Open
@colinodell
Copy link
Member

Thanks for working on this! I left some pointers on your original proposal which should hopefully help here.

colinodell
colinodell requested changes Jul 31, 2023
View reviewed changes
src/Util/RegexHelper.php Outdated Show resolved Hide resolved
src/Extension/Attributes/Util/AttributesHelper.php Outdated Show resolved Hide resolved
tests/unit/Extension/Attributes/Util/AttributesHelperTest.php Outdated Show resolved Hide resolved
@svenluijten
Copy link
Contributor Author

Thanks for the pointers! I'll work them out later today. Meanwhile, do you want me to point this PR to main? Seeing as you added the issue to the 2.5 milestone?

@colinodell
Copy link
Member

colinodell commented Jul 31, 2023 •
edited

Meanwhile, do you want me to point this PR to main? Seeing as you added #985 to the 2.5 milestone?

Ah, yes please! Edit: looks like I can do that :)

@colinodell colinodell changed the base branch from 2.4 to main July 31, 2023 15:55
colinodell
colinodell approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@colinodell colinodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@svenluijten
Copy link
Contributor Author

FWIW, this is what I was working on when I thought I could use valueless attributes 🙂

@colinodell colinodell merged commit 2138460 into thephpleague:main Jul 31, 2023
13 of 14 checks passed
@colinodell colinodell added this to the v2.5 milestone Jul 31, 2023
@colinodell
Copy link
Member

This change will be available in the future 2.5.0 release. It may be a little while before that gets tagged, as I'm hoping to include some additional (unrelated) changes at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinodell colinodell colinodell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5
Development

Successfully merging this pull request may close these issues.

Allow setting attributes without values in Attributes extension
2 participants
@svenluijten @colinodell