Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rendering approach #720

Open
6 tasks
colinodell opened this issue Sep 20, 2021 · 0 comments
Open
6 tasks

Refactor rendering approach #720

colinodell opened this issue Sep 20, 2021 · 0 comments
Assignees
Labels
do not close Issue which won't close due to inactivity enhancement New functionality or behavior performance Something could be made faster or more efficient
Milestone

Comments

@colinodell
Copy link
Member

colinodell commented Sep 20, 2021

There are several rendering-related ideas I'd like to explore for v3:

  • Avoiding recursion (parsing and AST iteration already avoid recursion)
  • Using an OutputWriter object
  • Investigate performance of writing to a php://memory stream instead of concatenating strings
  • Allowing renderers to determine what to render (à la Symfony's NormalizerInterface) so that renderers could potentially handle multiple node types without needing to tell the Environment in advance
  • Better support for multiple render formats (html, md, xml)
  • Simplifying the creation of custom renderers (see Simplify custom renderers #967)

Whether these actually get implemented will depend on how the testing goes.

@colinodell colinodell added enhancement New functionality or behavior performance Something could be made faster or more efficient do not close Issue which won't close due to inactivity labels Sep 20, 2021
@colinodell colinodell added this to the v3.0 milestone Sep 20, 2021
@colinodell colinodell self-assigned this Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not close Issue which won't close due to inactivity enhancement New functionality or behavior performance Something could be made faster or more efficient
Projects
None yet
Development

No branches or pull requests

1 participant