Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bothan.io Bothan Deploy hangs on name with <=2 chars #201

Open
quadrophobiac opened this issue Apr 6, 2017 · 8 comments
Open

Bothan.io Bothan Deploy hangs on name with <=2 chars #201

quadrophobiac opened this issue Apr 6, 2017 · 8 comments

Comments

@quadrophobiac
Copy link
Collaborator

following the bothan deploy from bothan.io to heroku currently hangs and does not create the app

@quadrophobiac
Copy link
Collaborator Author

repeated auto deploy and now it works fine. Seeing as I didn't capture any logs at the time this happened it's going to be hard to determine what (if anything) has changed, so closing this for now

@Floppy
Copy link
Contributor

Floppy commented Apr 27, 2017

Oh, that's very odd.

@Floppy
Copy link
Contributor

Floppy commented Apr 27, 2017

@agentGav was experiencing this as well. Gavin, do you mind retrying the bothan deployment as it's working here OK now?

@pezholio
Copy link
Collaborator

Is it worth getting Airbrake here so we can track fails?

@agentGav
Copy link

agentGav commented Apr 27, 2017 via email

@Floppy
Copy link
Contributor

Floppy commented Apr 28, 2017

AHA, ok. Trust you to find a degenerate corner case. We can add validation to the input field to make sure it's >=3 chars.

@Floppy Floppy reopened this Apr 28, 2017
@Floppy Floppy changed the title Bothan.io Bothan Deploy hangs Bothan.io Bothan Deploy hangs on name with <3 chars Apr 28, 2017
@quadrophobiac
Copy link
Collaborator Author

So I literally can't replicate this because so many 3 char combinations appear to trigger Application name $$$ is not available. I'll add the validation rule that @Floppy suggested, but I'm decreasing the severity of this because I think it's a hard to access edge case

@Floppy
Copy link
Contributor

Floppy commented Jul 26, 2017

I think the issue is with less than 3, so the validation should be enough.

@quadrophobiac quadrophobiac changed the title Bothan.io Bothan Deploy hangs on name with <3 chars Bothan.io Bothan Deploy hangs on name with <=2 chars Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants