{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":438202189,"defaultBranch":"main","name":"shaka-player","ownerLogin":"theodab","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2021-12-14T10:01:26.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/21047092?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1717584466.0","currentOid":""},"activityList":{"items":[{"before":"dc3bcd62661ea07fb7e41de5220d20334d8b9fba","after":null,"ref":"refs/heads/destroyAllPreloadBranch","pushedAt":"2024-06-05T10:47:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"}},{"before":"cdbe54769cdec9280d5510c470cd795402b505bc","after":"dc3bcd62661ea07fb7e41de5220d20334d8b9fba","ref":"refs/heads/destroyAllPreloadBranch","pushedAt":"2024-06-05T08:47:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"Add to cast test exceptions.","shortMessageHtmlLink":"Add to cast test exceptions."}},{"before":"9378fc2fea8862f04a2d54261b950f4f0563b983","after":"cdbe54769cdec9280d5510c470cd795402b505bc","ref":"refs/heads/destroyAllPreloadBranch","pushedAt":"2024-06-05T08:22:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"Fixed another typo.","shortMessageHtmlLink":"Fixed another typo."}},{"before":"cb41b0092497a4d13219e2dbc63a2929e8848ba6","after":"9378fc2fea8862f04a2d54261b950f4f0563b983","ref":"refs/heads/destroyAllPreloadBranch","pushedAt":"2024-06-05T08:19:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"Changed it again.","shortMessageHtmlLink":"Changed it again."}},{"before":"3375edc97a8b40492e847cd250f3c84402b8d764","after":"cb41b0092497a4d13219e2dbc63a2929e8848ba6","ref":"refs/heads/destroyAllPreloadBranch","pushedAt":"2024-06-05T08:09:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"Add missing await.","shortMessageHtmlLink":"Add missing await."}},{"before":null,"after":"3375edc97a8b40492e847cd250f3c84402b8d764","ref":"refs/heads/destroyAllPreloadBranch","pushedAt":"2024-06-05T07:57:41.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"feat(preload): Add new method destroyAllPreloads","shortMessageHtmlLink":"feat(preload): Add new method destroyAllPreloads"}},{"before":"8154298ae3da28f7f463471ff8dc923fde59b793","after":null,"ref":"refs/heads/preloadErrorFixBranchToo","pushedAt":"2024-06-04T23:45:14.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"}},{"before":"e891d3253c0812d0cfdc5c86ad07b4761960a311","after":"8154298ae3da28f7f463471ff8dc923fde59b793","ref":"refs/heads/preloadErrorFixBranchToo","pushedAt":"2024-06-04T21:59:30.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"joeyparrish","name":"Joey Parrish","path":"/joeyparrish","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6843156?s=80&v=4"},"commit":{"message":"Fix remaining errors","shortMessageHtmlLink":"Fix remaining errors"}},{"before":"96167eb43bfb74ffe80721bd2e06489969dda44f","after":"e891d3253c0812d0cfdc5c86ad07b4761960a311","ref":"refs/heads/preloadErrorFixBranchToo","pushedAt":"2024-06-04T21:29:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joeyparrish","name":"Joey Parrish","path":"/joeyparrish","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6843156?s=80&v=4"},"commit":{"message":"Fix linter","shortMessageHtmlLink":"Fix linter"}},{"before":"390b7cb8bf4936da68ba42fa854df0850f444740","after":"96167eb43bfb74ffe80721bd2e06489969dda44f","ref":"refs/heads/preloadErrorFixBranchToo","pushedAt":"2024-06-04T21:27:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joeyparrish","name":"Joey Parrish","path":"/joeyparrish","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6843156?s=80&v=4"},"commit":{"message":"Add missing destruction checks after async processes","shortMessageHtmlLink":"Add missing destruction checks after async processes"}},{"before":"98144e800ac0123e32fa5538452554204e4d64a1","after":"390b7cb8bf4936da68ba42fa854df0850f444740","ref":"refs/heads/preloadErrorFixBranchToo","pushedAt":"2024-06-04T21:00:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joeyparrish","name":"Joey Parrish","path":"/joeyparrish","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6843156?s=80&v=4"},"commit":{"message":"Fix test","shortMessageHtmlLink":"Fix test"}},{"before":"405f6e43b3ee3dc3c3d61e8a0378cd95160952bc","after":"98144e800ac0123e32fa5538452554204e4d64a1","ref":"refs/heads/preloadErrorFixBranchToo","pushedAt":"2024-06-04T20:34:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joeyparrish","name":"Joey Parrish","path":"/joeyparrish","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6843156?s=80&v=4"},"commit":{"message":"Fix uncaught errors in Player exposed by tests","shortMessageHtmlLink":"Fix uncaught errors in Player exposed by tests"}},{"before":"f2eeefd0e0889a4182324774ffb216f07ebb5ea1","after":"405f6e43b3ee3dc3c3d61e8a0378cd95160952bc","ref":"refs/heads/preloadErrorFixBranchToo","pushedAt":"2024-06-04T18:22:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"Just remove destroyPromise_ entirely.","shortMessageHtmlLink":"Just remove destroyPromise_ entirely."}},{"before":"d62d0f754ac64b9781dd8a3b20c7bdfa840ad4ad","after":null,"ref":"refs/heads/preloadErrorFixBranch","pushedAt":"2024-06-04T18:17:59.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"}},{"before":"082f89770165963cda5797bbe51966c72f6d4535","after":"95422b17d62964f45528061b678651081910c184","ref":"refs/heads/main","pushedAt":"2024-06-04T18:17:34.000Z","pushType":"push","commitsCount":21,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"fix(preload): Fix preload error reporting (#6746)","shortMessageHtmlLink":"fix(preload): Fix preload error reporting (shaka-project#6746)"}},{"before":null,"after":"f2eeefd0e0889a4182324774ffb216f07ebb5ea1","ref":"refs/heads/preloadErrorFixBranchToo","pushedAt":"2024-06-04T18:16:14.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"fix(preload): Pass errors through successPromise.\n\nPreviously, preload errors were passed through the destroyPromise,\nwhich is contrary to our normal practices.","shortMessageHtmlLink":"fix(preload): Pass errors through successPromise."}},{"before":"fd6da50d8bc83e67c6104debaae15f8083a89539","after":"d62d0f754ac64b9781dd8a3b20c7bdfa840ad4ad","ref":"refs/heads/preloadErrorFixBranch","pushedAt":"2024-06-04T18:10:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"fix(preload): Pass errors through successPromise.\n\nPreviously, preload errors were passed through the destroyPromise,\nwhich is contrary to our normal practices.","shortMessageHtmlLink":"fix(preload): Pass errors through successPromise."}},{"before":"57aeb19ea1a8f6e332c768b1b6beb07355bbbdd2","after":"fd6da50d8bc83e67c6104debaae15f8083a89539","ref":"refs/heads/preloadErrorFixBranch","pushedAt":"2024-06-04T10:38:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"fix(preload): Fix preload error reporting","shortMessageHtmlLink":"fix(preload): Fix preload error reporting"}},{"before":"de3808c7aae782bde4285356821863297b614c7c","after":"57aeb19ea1a8f6e332c768b1b6beb07355bbbdd2","ref":"refs/heads/preloadErrorFixBranch","pushedAt":"2024-06-04T10:37:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"fix(preload): Fix preload error reporting","shortMessageHtmlLink":"fix(preload): Fix preload error reporting"}},{"before":"da74464ecfa6e8e2a0ff13378ad5fba801136bc8","after":"de3808c7aae782bde4285356821863297b614c7c","ref":"refs/heads/preloadErrorFixBranch","pushedAt":"2024-06-04T10:29:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"fix(preload): Fix preload error reporting","shortMessageHtmlLink":"fix(preload): Fix preload error reporting"}},{"before":null,"after":"da74464ecfa6e8e2a0ff13378ad5fba801136bc8","ref":"refs/heads/preloadErrorFixBranch","pushedAt":"2024-06-04T10:28:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"fix(preload): Fix preload error reporting","shortMessageHtmlLink":"fix(preload): Fix preload error reporting"}},{"before":"7210b0c868edcf3a1381995c4c061c0d3a65833a","after":null,"ref":"refs/heads/copyNetBranch","pushedAt":"2024-05-30T11:05:02.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"}},{"before":null,"after":"7210b0c868edcf3a1381995c4c061c0d3a65833a","ref":"refs/heads/copyNetBranch","pushedAt":"2024-05-30T10:01:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"fix(preload): Copy net filters to preload manager\n\nSome assets might rely on networking engine filters (request and\nresponse filters) to properly download their assets.\nHowever, the preload manager's need to use a fresh networking engine\nalso caused it to not use any filters set on the player already.\nThis changes the process of setting up a preload manager, to make it\ncopy over any filters defined on the player's networking engine.\n\nIssue #6698","shortMessageHtmlLink":"fix(preload): Copy net filters to preload manager"}},{"before":"907e6bab287a61f160f2a3f6f942c44c325d96e6","after":"082f89770165963cda5797bbe51966c72f6d4535","ref":"refs/heads/main","pushedAt":"2024-05-30T09:12:15.000Z","pushType":"push","commitsCount":58,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"feat(HLS): Build closed captions metadata on-the-fly (#6700)\n\nCloses https://github.com/shaka-project/shaka-player/issues/1826\r\n\r\nAlso fixes variable substitution when using `getMediaPlaylistBasicInfo_`","shortMessageHtmlLink":"feat(HLS): Build closed captions metadata on-the-fly (shaka-project#6700"}},{"before":"be60f40cd71b5782d8386c73a0d426fa8e60dded","after":"907e6bab287a61f160f2a3f6f942c44c325d96e6","ref":"refs/heads/main","pushedAt":"2024-05-17T09:11:36.000Z","pushType":"push","commitsCount":24,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"feat: Add getNonDefaultConfiguration (#6620)","shortMessageHtmlLink":"feat: Add getNonDefaultConfiguration (shaka-project#6620)"}},{"before":"4eb63edbcb24053e113fa264070ff5b26fc4228f","after":"be60f40cd71b5782d8386c73a0d426fa8e60dded","ref":"refs/heads/main","pushedAt":"2024-05-11T07:14:57.000Z","pushType":"push","commitsCount":20,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"fix: Clear preload array before awaiting destroy (#6584)\n\nThis could be relevant if destroy() is called multiple times in a row.\r\n\r\nBased on a comment on #6576","shortMessageHtmlLink":"fix: Clear preload array before awaiting destroy (shaka-project#6584)"}},{"before":"06086df6f0e05fcbe18921e171c329ad0f877e45","after":null,"ref":"refs/heads/awaitOrderBranch","pushedAt":"2024-05-11T07:14:32.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"}},{"before":null,"after":"06086df6f0e05fcbe18921e171c329ad0f877e45","ref":"refs/heads/awaitOrderBranch","pushedAt":"2024-05-11T05:31:12.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"fix: Clear preload array before awaiting destroy\n\nBased on a comment on #6576","shortMessageHtmlLink":"fix: Clear preload array before awaiting destroy"}},{"before":"b256e998d94e89e6a91f43c61ba8bbe02ba96019","after":null,"ref":"refs/heads/autoDestroyPreloadManagerBranch","pushedAt":"2024-05-11T05:29:42.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"}},{"before":"d114005a2e74c5aedc68dc33481fde9e83341e98","after":"b256e998d94e89e6a91f43c61ba8bbe02ba96019","ref":"refs/heads/autoDestroyPreloadManagerBranch","pushedAt":"2024-05-10T10:02:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theodab","name":null,"path":"/theodab","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21047092?s=80&v=4"},"commit":{"message":"fix: Destroy preload managers on player destroy\n\nA PreloadManager can only be used on the Player instance that created\nit. That means that once that Player instance is destroyed any\nPreloadManagers it made are basically useless, so they should be\nautomatically destroyed too.","shortMessageHtmlLink":"fix: Destroy preload managers on player destroy"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEXP9XpQA","startCursor":null,"endCursor":null}},"title":"Activity ยท theodab/shaka-player"}