Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Molecular Grid from Atomic Grids #179

Open
PaulWAyers opened this issue Aug 17, 2023 · 4 comments
Open

Molecular Grid from Atomic Grids #179

PaulWAyers opened this issue Aug 17, 2023 · 4 comments
Assignees

Comments

@PaulWAyers
Copy link
Member

There should be an easy-to-use functionality to get molecular grids from atomic grids, as well as an overall wrapper to take atomic positions and types and construct atomic grids directly, then molecular grids.

@PaulWAyers
Copy link
Member Author

A starting point is to add a notebook that shows how to construct a molecular grid from atomic grids.

@Ali-Tehrani
Copy link
Collaborator

Ali-Tehrani commented Aug 31, 2023

I agree with adding in the notebook on how to construct it using the initializer but I feel like the init method achieves the easy-to-use functionality if the user has an example

grid/src/grid/molgrid.py

Lines 92 to 98 in cdf1ec3

def __init__(
self,
atnums: np.ndarray,
atgrids: list,
aim_weights: Union[callable, np.ndarray],
store: bool = False,
):

There is also an example of using init in the code docs of molecular grid

The latter wrapper will depend on the radial grid and consequently the results of the grid assessment for picking a default radial grid

@Ali-Tehrani
Copy link
Collaborator

Until grid assessment is done, the default construction methods in mol_grid would be changed so that the rgrid methods and aim_weights are from Horton/Becke Weights, respectively.

@FarnazH
Copy link
Member

FarnazH commented Dec 24, 2023

  • Address comments 1 and 2 from Atomgrid examples #199 (review)
  • Double check the 2nd formula in the “Calculate Radial Electron Density Distribution” section
  • Probably we can identify the maximum radial electron density distribution using scipy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants