Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poisson Solver initial value problem implementation is not robust. #162

Open
PaulWAyers opened this issue May 11, 2023 · 4 comments
Open
Labels
good first issue Good for newcomers

Comments

@PaulWAyers
Copy link
Member

The current boundary-value-problem for the Poisson solver is pretty robust. The initial value problem is a lot less robust.

It's a good first issue to try to make this work more efficiently. I will post some notes on how to do this.

@PaulWAyers PaulWAyers added the good first issue Good for newcomers label May 11, 2023
@Aditish51
Copy link

@PaulWAyers Can you please give me more details on it? I would like to work on it.

@Charlie-1-3
Copy link

The current code uses a large initial interval (r_interval[0]) for the IVP solver. This might be unnecessary, especially if f decays rapidly with increasing r. Reducing the initial interval to a value just larger than the region of interest can potentially improve performance.

@PaulWAyers
Copy link
Member Author

@Charlie-1-3 did you test it to see if this helped?

@Ali-Tehrani do you have some examples for this? I seem to recall that Carlos had an example that was problematic, but I don't remember for certain.

@Charlie-1-3
Copy link

@PaulWAyers Yes it worked for a few test cases where function f was inversely proportional to r. Cases, when f depends directly on r, might add extra computation in IVP because of larger domain traversal.
Use of Relaxation Techniques for Poisson’s Equation one of which is Successive Over-Relaxation (SOR) would help too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants