Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mysql with mysql2 #345

Closed
3 tasks
goloroden opened this issue Dec 10, 2019 · 1 comment
Closed
3 tasks

Replace mysql with mysql2 #345

goloroden opened this issue Dec 10, 2019 · 1 comment

Comments

@goloroden
Copy link
Member

What is this task about?

The mysql npm package does not seem to be alive any more. Hence we should migrate to mysql2, especially given that it supports a promise-based API out of the box. However, it is missing official @types support. So we may need to work around this.

What needs to be done to complete this task?

  • Replace the npm dependency
  • Switch to the promise-based API
  • Add missing types (and maybe contribute back)

What else should we know?

This is needed to prepare support for MySQL 8.

@goloroden goloroden added this to Next version in wolkenkit Dec 10, 2019
This was referenced Dec 10, 2019
@goloroden
Copy link
Member Author

Good news on the mysql package, apparently something is going on there, and there should be a new version with support for MySQL 8 in early 2020 (see mysqljs/mysql#2233 (comment) for details).

Hence, let's hope the best, and let's close this issue for now.

wolkenkit automation moved this from Next version to Done Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
wolkenkit
  
Done
Development

No branches or pull requests

1 participant