Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate +/- size on mobile #649

Open
zorbathut opened this issue Jul 24, 2023 · 3 comments
Open

Evaluate +/- size on mobile #649

zorbathut opened this issue Jul 24, 2023 · 3 comments
Labels
enhancement New feature or request P3 desired

Comments

@zorbathut
Copy link
Contributor

I think on mobile the "+" and "-" symbols to expand/collapse a child thread should be bigger. A lot of times when I try to hit those I miss and accidentally collapse the top level thread instead.

--

Might just be that the symbols should remain the same size but the hit area should be boosted.

If you're someone who isn't me working on this, please attach some screenshots :)

@zorbathut zorbathut added enhancement New feature or request P3 desired labels Jul 24, 2023
@justcool393
Copy link
Collaborator

image
here's a screenshot from Firefox pretending to be an S10.

image
attached here is the hitboxes. it does look like they're quite tiny on mobile.

in a deeper subthread here's what it looks like

image

the vertical space needed to hit the collapse thing on the correct subthread is quite small and it is quite easy to overshoot

@zorbathut
Copy link
Contributor Author

Ah, hrm. Now I'm remembering part of the problem; I need a narrow space to avoid shoving everything over to the side all the time, but I also wanted the ability to be able to touch the bar to collapse, which is something desktop has.

(this theme seems to have invisible bars)

It's possible those are just not compatible and I should be de-touch-sensitivity'ing the bars on mobile, then making the -/+ hitbox wider horizontally.

@justcool393
Copy link
Collaborator

image
example from TheMotte theme

but yeah it seems that maybe detouchsenstifying the bars themselves might be a good idea. which ironically makes the actual hitbox smaller but it'd probably be less annoying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3 desired
Projects
None yet
Development

No branches or pull requests

2 participants