Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logistics/infrastructure required for highlight images #50

Open
JonEsparaz opened this issue Aug 20, 2020 · 2 comments
Open

Logistics/infrastructure required for highlight images #50

JonEsparaz opened this issue Aug 20, 2020 · 2 comments

Comments

@JonEsparaz
Copy link
Collaborator

JonEsparaz commented Aug 20, 2020

I'm having issues cropping these highlight images:
Highlights w Subtitle.

Unfortunately React Native doesn't have anything like object-position in CSS. There's an Expo supported image manipulator library, but it requires the image to be on the local file system and definitely has performance drawbacks. I attempted to use WebView with CSS and a solution from Stack Overflow, but neither worked.

I think manually cropping and uploading the images is required if we want to keep this design feature.

┆Issue is synchronized with this Wrike Task

@JonEsparaz
Copy link
Collaborator Author

For future development (we will launch with the 16:9 images)...

A good way to automate this is a Python script in GitHub actions that crops (and downscales) the image, then performs a checkout to https://github.com/themeetinghouse/web. We can tell which highlight videos have already had the thumbnail processed by naming the files <youtubeId>.jpg. If we want to get fancy, OpenCV is a good option for detecting faces to get the optimal crop.

@GeorgeBellTMH
Copy link
Contributor

GeorgeBellTMH commented Aug 26, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Winter release
  
To do
Development

No branches or pull requests

2 participants