Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC break in patch release 2.2.3 #392

Closed
davidyell opened this issue Sep 15, 2022 · 2 comments
Closed

BC break in patch release 2.2.3 #392

davidyell opened this issue Sep 15, 2022 · 2 comments

Comments

@davidyell
Copy link

davidyell commented Sep 15, 2022

In my work project we implement the json_decode method and it seems there is a method signature change between 2.2.2 and 2.2.3 which breaks our codebase.

I am curious why the method params would be changed outside of a major release in-line with Semver. https://semver.org/

If this is an intentional change, then I would recommend some documentation around it, as stipulating a Composer constraint of ^2.0 and implementing the class with a pre 2.2.3 release, when using composer update the code will break.

https://getcomposer.org/doc/articles/versions.md#caret-version-range-

The intention of this constraint is that updates should be safe.

@colinodell
Copy link
Contributor

There's some further discussion of this in #376 (comment)

@davidyell
Copy link
Author

Thanks @colinodell

I will close this as duplicate of that discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants