Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: FIX: changed openssl functions typehinting from ressource to OpenSSLCertificate #381

Merged
merged 2 commits into from Sep 5, 2022

Conversation

Kharhamel
Copy link
Collaborator

@Kharhamel Kharhamel commented Aug 20, 2022

This should fix #380

TODO:

  • change the typehints of the other functions
  • see if updating phpstan fix this issue

@codecov-commenter
Copy link

Codecov Report

Merging #381 (7df7673) into master (6a4c59f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #381   +/-   ##
=========================================
  Coverage     49.24%   49.24%           
  Complexity      314      314           
=========================================
  Files            16       16           
  Lines           794      794           
=========================================
  Hits            391      391           
  Misses          403      403           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Kharhamel Kharhamel changed the title FIX: changed openssl functions typehinting from ressource to OpenSSLCertificate WIP: FIX: changed openssl functions typehinting from ressource to OpenSSLCertificate Aug 20, 2022
@Kharhamel
Copy link
Collaborator Author

I think i will merge this today. If I missed some functions I will do it later

@Kharhamel Kharhamel merged commit 14fe494 into master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type on openssl_ functions
2 participants