New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rector-migrate.php
#375
Comments
@dbrekelmans yes, it will, but will break compatibility with older versions. The code I proposed maintains backward compatibility. |
I just saw you released the version This change, however, is potentially backward breaking change, so it should have been merged in a major release if you follow the semver. Using the code I suggested, instead, it would not break backward compatibility and can be released also in a patch release. My 2 cents. |
Sorry I was in holidays for the last 2 weeks, i didn't see your thread. We definitly don't want to break semVer. If you are confident about your code, i am in favor of merging it over #372 and quickly publishing a new tag to cover our mistake. @dbrekelmans what do you think? |
Agreed. I would be in favor of doing a new patch release after this is merged. |
I will try to do it tomorrow |
Thanks a lot for the suggested patch. Real question here: Do we want to ensure SEMVER for Rector? I mean, it is not run at runtime, and I doubt someone is running this in a CI/CD too. Shouldn't we exclude it from semver support? (I'm saying this because if at some point, we cannot do rector-migrate file that supports all rector versions, I'd rather drop support for older Rector releases than prevent Safe users to use a newer Rector release. |
The new configuration is this:
To support older versions:
The text was updated successfully, but these errors were encountered: