Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapTTL seems to be not set by default and can't be configured #350

Open
Lappihuan opened this issue Jun 13, 2021 · 3 comments
Open

mapTTL seems to be not set by default and can't be configured #350

Lappihuan opened this issue Jun 13, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@Lappihuan
Copy link
Contributor

mapTTL seems to be intended to controll the Cache of TypeMappers.

It is implemented up to the FactoryContext but the SchemaFactory is not exposing it, nor setting it, which leaves it null for ever.
From my understanding this could potentially be a performance boost on each request.

Is this intentional or an oversight?

@oojacoboo
Copy link
Collaborator

oojacoboo commented Jun 13, 2021

Wouldn't a null TTL value simply not expire the cache? How would specifying a TTL value, which expires the cache, improve performance?

@Lappihuan
Copy link
Contributor Author

I'm not sure, but that might be the case that a null value will cache forever.
It seems odd that the globTTL is always set but the mapTTL not.

@oojacoboo
Copy link
Collaborator

I don't have an issue with, or see an issue, with exposing this property if you'd like to submit a PR. Maybe @moufmouf can chime in on this.

@oojacoboo oojacoboo added the enhancement New feature or request label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants