Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menu not responsive #166

Open
acuvic opened this issue Mar 24, 2019 · 11 comments · May be fixed by #638
Open

menu not responsive #166

acuvic opened this issue Mar 24, 2019 · 11 comments · May be fixed by #638
Assignees
Milestone

Comments

@acuvic
Copy link

acuvic commented Mar 24, 2019

Although the theme is listed as responsive, the navigation menu does not seem to be. Smaller screen does not give the "hamburger"(3 bar) menu. This is ok with the demo site it has only three menu items with short names that just folds into one line under the site title on smaller screens. With larger number of menu items, they all fold into multiple lines.

@budparr
Copy link
Member

budparr commented Mar 26, 2019

A hamburger menu does not define it as responsive, but I'm happy to make a better solution for longer menus. Do you have an example site I can look at? If not, how many menu items do you have?

@budparr budparr self-assigned this Mar 26, 2019
@acuvic
Copy link
Author

acuvic commented Mar 26, 2019 via email

@mcolburn
Copy link

I also vote for adding collapsible menus to Ananke so it displays well on mobile devices.

@budparr budparr added this to the 3.0 milestone Sep 16, 2019
@jan-xyz
Copy link
Contributor

jan-xyz commented Apr 5, 2020

This theme has a responsive header menu like Ananke that folds into a single item with drop down:
https://github.com/Vimux/Mainroad

This one has a side-menu that turns into a burger:
https://github.com/alex-shpak/hugo-book.git

sumpfralle added a commit to sumpfralle/gohugo-theme-ananke that referenced this issue Jun 12, 2020
* add some IDs to elements of the main navigation
* add styles for mobile view (up to 768px wide) for collapsing the menu
  items into a "hamburger" menu

Closes: theNewDynamic#166
sumpfralle added a commit to sumpfralle/gohugo-theme-ananke that referenced this issue Jun 13, 2020
* add some IDs to elements of the main navigation
* add styles for mobile view (up to 768px wide) for collapsing the menu
  items into a "hamburger" menu

Closes: theNewDynamic#166
@deltreey
Copy link

someone had proposed this for bootstrap 3 @ twbs/bootstrap#15786
Here's their fiddle: https://jsbin.com/lugosozida/edit?html,css,output

Perhaps it could be adjusted to work for our usage?

@freekvh
Copy link

freekvh commented Oct 24, 2022

I would really like it if my pretty large menu (especially the one in my native language!) would collapse into a hamburger on mobile (reduced width screens). So consider this a vote :)

Thanx for the great work.

@ctindel
Copy link

ctindel commented May 17, 2023

@budparr I found this open issue because like others I too thought this theme was responsive based on the website and was surprised to find that the menu doesn’t convert to hamburger style on mobile like many other Hugo themes.

Is there any work in flight on this that you know of? This theme is so nice and clean and simple, I could take a crack at it but didn’t want to duplicate work.

Just as examples these are two other sites with Hugo themes that I used that have hamburgers on mobile:

https://www.softwareinblue.com/

https://www.learningfromthelegends.com/

And my ananke site on mobile you can see the menu does not look good as it wraps around:

image

@budparr
Copy link
Member

budparr commented May 17, 2023

Thanks, @ctindel We definitely welcome PRs on this.

@ctindel
Copy link

ctindel commented May 17, 2023

OK, I didn't realize this theme was using tachyons for CSS instead of something more common like bootstrap. Tachyons itself doesn't even have a responsive website (try looking at https://tachyons.io on mobile, the menu gets cut off), not a great look for a CSS package haha.

Let me play around with it and see what I can dig up.

@ctindel
Copy link

ctindel commented May 17, 2023

@budparr OK I've created this PR

#638

If you want to test it out and give me some feedback. I am not a CSS expert by any means so possibly it needs some tweaking I don't know. Let me know what you think.

@leroivi
Copy link

leroivi commented May 18, 2024

Hi,
I was searching for this feature, thank you for making progress on the subject.

My feedback is that this PR is what I was looking for, I just think that the rows of the menu are too small, it is too easy to click on the wrong line with big fingers. Also, an option could be added to remove the burger for menus with few elements that does not needs to collapse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment