You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had been hoping that we could get away with simple offset/limit pagination, particularly because all the extra objects can be a bit overwhelming to GraphQL newcomers... however, it appears that TCG may be interested in adopting GraphQL in places where this is not feasible, and cursor-based pagination will be necessary. The latter is a far superior way of addressing the problem, so if the learning is going to happen, we might as well begin enforcing this best practice here.
Because it is such a well-establiished convention, we will follow the semantics outlined in relay's connection spec. Until this RFC lands in GraphQL, it will be impractical to describe this as an interface, and we will instead have to just follow the naming scheme.
The text was updated successfully, but these errors were encountered:
This is a breaking change to the GraphQL API (which is fine, as this is still in beta). @lolosett@arnav-aggarwal@zepfan you may want to check out the relay connection specification which I'll be implementing anywhere there is a potentially large list returned.
It's a bit verbose (which is why I was hesitant to introduce it) but incredibly flexible. It essentially allows me to implement offset-based pagination now, then transparently switch to something more performant without any API changes.
I had been hoping that we could get away with simple offset/limit pagination, particularly because all the extra objects can be a bit overwhelming to GraphQL newcomers... however, it appears that TCG may be interested in adopting GraphQL in places where this is not feasible, and cursor-based pagination will be necessary. The latter is a far superior way of addressing the problem, so if the learning is going to happen, we might as well begin enforcing this best practice here.
Because it is such a well-establiished convention, we will follow the semantics outlined in relay's connection spec. Until this RFC lands in GraphQL, it will be impractical to describe this as an interface, and we will instead have to just follow the naming scheme.
The text was updated successfully, but these errors were encountered: