From f2b83042673090fe74a1fd636953bf256982d43d Mon Sep 17 00:00:00 2001 From: Matej Gera Date: Mon, 13 Jun 2022 09:46:57 +0200 Subject: [PATCH 1/3] Change default eval interval to 1m Signed-off-by: Matej Gera --- cmd/thanos/rule.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/thanos/rule.go b/cmd/thanos/rule.go index cec7c66022..f1f788e5c7 100644 --- a/cmd/thanos/rule.go +++ b/cmd/thanos/rule.go @@ -125,7 +125,7 @@ func registerRule(app *extkingpin.App) { cmd.Flag("resend-delay", "Minimum amount of time to wait before resending an alert to Alertmanager."). Default("1m").DurationVar(&conf.resendDelay) cmd.Flag("eval-interval", "The default evaluation interval to use."). - Default("30s").DurationVar(&conf.evalInterval) + Default("1m").DurationVar(&conf.evalInterval) conf.rwConfig = extflag.RegisterPathOrContent(cmd, "remote-write.config", "YAML config for the remote-write configurations, that specify servers where samples should be sent to (see https://prometheus.io/docs/prometheus/latest/configuration/configuration/#remote_write). This automatically enables stateless mode for ruler and no series will be stored in the ruler's TSDB. If an empty config (or file) is provided, the flag is ignored and ruler is run with its own TSDB.", extflag.WithEnvSubstitution()) From 51d8fd6028713c503574bb70febdafd8b5a394fe Mon Sep 17 00:00:00 2001 From: Matej Gera Date: Mon, 13 Jun 2022 11:03:32 +0200 Subject: [PATCH 2/3] Update CHANGELOG Signed-off-by: Matej Gera --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b14a61df1f..1922781b40 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re ### Changed - [#5410](https://github.com/thanos-io/thanos/pull/5410) Query: Close() after using query. This should reduce bumps in memory allocations. +- [#5417](https://github.com/thanos-io/thanos/pull/5417) Ruler: Change default evaluation interval to 1 minute. ### Removed From 486492252b32615d16c10f176813525fe65934c3 Mon Sep 17 00:00:00 2001 From: Matej Gera Date: Mon, 13 Jun 2022 11:13:56 +0200 Subject: [PATCH 3/3] Regenerate rule docs Signed-off-by: Matej Gera --- docs/components/rule.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/components/rule.md b/docs/components/rule.md index 5c2f81f8fe..1cabaca15c 100644 --- a/docs/components/rule.md +++ b/docs/components/rule.md @@ -310,7 +310,7 @@ Flags: record's value. The URL path is used as a prefix for the regular Alertmanager API path. --data-dir="data/" data directory - --eval-interval=30s The default evaluation interval to use. + --eval-interval=1m The default evaluation interval to use. --grpc-address="0.0.0.0:10901" Listen ip:port address for gRPC endpoints (StoreAPI). Make sure this address is routable