Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore blocks with deletion markers #5231

Merged
merged 3 commits into from Mar 14, 2022
Merged

ignore blocks with deletion markers #5231

merged 3 commits into from Mar 14, 2022

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Mar 13, 2022 •
edited

Signed-off-by: Ben Ye ben.ye@bytedance.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #5228. Ignores deletion markers.

Verification

ignore blocks with deletion markers
ff0d256 
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
update changelog
fe6e5c1 
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
GiedriusS
GiedriusS reviewed Mar 14, 2022
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion

cmd/thanos/tools_bucket.go Outdated Show resolved Hide resolved
use fetcher concurrency
01c42db 
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
@yeya24
Copy link
Contributor Author

yeya24 commented Mar 14, 2022

I have seen this error quite often.

image

@yeya24 yeya24 enabled auto-merge (squash) March 14, 2022 19:35
@yeya24 yeya24 merged commit b096db1 into thanos-io:main Mar 14, 2022
@GiedriusS
Copy link
Member

#5181 fixes that problem, waiting for @matej-g

@yeya24 yeya24 deleted the verify-deletion-marker branch March 14, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bucket verify ignoring deletion-mark
2 participants
@yeya24 @GiedriusS