Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query-frontend: support forward-header to downstream querier #5220

Merged
merged 1 commit into from Mar 13, 2022
Merged

query-frontend: support forward-header to downstream querier #5220

merged 1 commit into from Mar 13, 2022

Conversation

lcasi
Copy link
Contributor

@lcasi lcasi commented Mar 7, 2022 •
edited

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Add --query-frontend.forward-header flag to support headers forward from query-frontend to downstream querier

Verification

Tested it locally

@lcasi lcasi force-pushed the feature/forward-header branch 3 times, most recently from 3bb0445 to b762212 Compare March 7, 2022 13:04
GiedriusS
GiedriusS reviewed Mar 8, 2022
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the docs 😄 (https://github.com/thanos-io/thanos/runs/5461075913?check_suite_focus=true). Also, maybe we could add to the documentation a sentence or two about this? For example, where this could be useful or what is your use case

@lcasi
support forward-header
db14a56 
Signed-off-by: lcasi <liuxin@bilibili.com>
@lcasi
Copy link
Contributor Author

lcasi commented Mar 8, 2022

Please update the docs smile (https://github.com/thanos-io/thanos/runs/5461075913?check_suite_focus=true). Also, maybe we could add to the documentation a sentence or two about this? For example, where this could be useful or what is your use case

Please update the docs smile (https://github.com/thanos-io/thanos/runs/5461075913?check_suite_focus=true). Also, maybe we could add to the documentation a sentence or two about this? For example, where this could be useful or what is your use case

I have updated the docs.

@lcasi
Copy link
Contributor Author

lcasi commented Mar 8, 2022

Hey @GiedriusS, I didn't update docs/release-process.md and maintainers.md, but doc check failed, could you please help me?

yeya24
yeya24 approved these changes Mar 13, 2022
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution @lcasi

@yeya24 yeya24 merged commit 6eb5ce6 into thanos-io:main Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS left review comments

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lcasi @GiedriusS @yeya24