Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run downsample tool continuously #5218

Merged
merged 2 commits into from Mar 8, 2022
Merged

Run downsample tool continuously #5218

merged 2 commits into from Mar 8, 2022

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Mar 7, 2022 •
edited

Signed-off-by: Ben Ye ben.ye@bytedance.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #5074

This makes the downsample tool run continuously and downsamples every 5m (configurable via flag).

Verification

run downsample tool continuously
dcfddca 
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
update changelog
5c288ea 
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
GiedriusS
GiedriusS approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Even the documentation says:

Continuously downsamples blocks in an object store bucket.

Now the documentation won't lie 😂

@GiedriusS GiedriusS merged commit 0c067eb into thanos-io:main Mar 8, 2022
@yeya24 yeya24 deleted the run-downsample-tools-continuously branch March 8, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thanos Tools Downsample Shutting Down without Reason
2 participants
@yeya24 @GiedriusS