Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup ExpandPostings call #7170

Open
yeya24 opened this issue Feb 29, 2024 · 0 comments · May be fixed by #7171
Open

Dedup ExpandPostings call #7170

yeya24 opened this issue Feb 29, 2024 · 0 comments · May be fixed by #7171

Comments

@yeya24
Copy link
Contributor

yeya24 commented Feb 29, 2024

Is your proposal related to a problem?

Similar to #7169, duplicate requests of expanding postings for the same matchers, can consume a lot of bandwidth and CPU.

Describe the solution you'd like

Introduce https://pkg.go.dev/golang.org/x/sync/singleflight to https://github.com/thanos-io/thanos/blob/main/pkg/store/bucket.go#L1099 to dedup ExpandPostings requests.

It is not enough to just do #7169 because #7169 only dedups requests to cache. However, postings insection/merge operations are still duplicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant