Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Make receiver relabelConfig reloadable #5398

Open
hanjm opened this issue May 31, 2022 · 6 comments
Open

[feature request] Make receiver relabelConfig reloadable #5398

hanjm opened this issue May 31, 2022 · 6 comments

Comments

@hanjm
Copy link
Member

hanjm commented May 31, 2022

Is your proposal related to a problem?

Thanks #5391 support relabel on receiver router, It is very useful feature to drop high cardinarly metrics to self protect.
It is static config, need reboot when config update.

Describe the solution you'd like

Use fsnotify watch file change and reload it.

Additional context

  1. Create metric about reload result and timestamp.
  2. Use atomic value instead of mutex lock, avoid block receiver ingest metric.
@piclemx
Copy link

piclemx commented May 31, 2022

@hanjm I can try to do that this week if you still need help.

@yeya24
Copy link
Contributor

yeya24 commented Jun 8, 2022

@piclemx Please go ahead. This feature would be a nice addition.

@stale
Copy link

stale bot commented Aug 13, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Aug 13, 2022
@juanrh
Copy link
Contributor

juanrh commented Sep 2, 2022

I'd like to work on this

@stale stale bot removed the stale label Sep 2, 2022
@piclemx
Copy link

piclemx commented Sep 2, 2022

@juanrh go ahead. I started something, but I drop it because I was changing too many things.

@juanrh
Copy link
Contributor

juanrh commented Sep 19, 2022

I have https://github.com/juanrh/thanos/commits/add-path-content-reloader-with-relabeller-2 for this but it depends on #5673 that adds a generic mechanism for reloading configuration. I should be able to have a PR for this soon after that is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants