Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--tracing.config to replace environment variables #5389

Closed
carlosjgp opened this issue May 27, 2022 · 4 comments
Closed

--tracing.config to replace environment variables #5389

carlosjgp opened this issue May 27, 2022 · 4 comments

Comments

@carlosjgp
Copy link

Is your proposal related to a problem?

When using OpenTelemetry agents (Deamonset) to ingest traces and decorate them with the node and pod metadata
container envs

- name: HOST_IP
  valueFrom:
    fieldRef:
      apiVersion: v1
      fieldPath: status.hostIP

flag

    --tracing.config=type: JAEGER
    config:
      service_name: "thanos"
      agent_host: "${HOST_IP}"
      agent_port: 14250

Describe the solution you'd like

Something similar for the tracing.config flag
#4327

(Describe your proposed solution here.)

Describe alternatives you've considered

Use OTEL Deployment with a Service but I'll lose important metadata

Additional context

Related with #1972

@matej-g
Copy link
Collaborator

matej-g commented May 30, 2022

I think this is a valid request 👍 Help needed! Would you be interested in taking this @carlosjgp?

@saswatamcode
Copy link
Member

I think we already have env substitution for --tracing.config flag as defined here. The env substitutions follows K8s style though so it would be something like this. :)

    --tracing.config=type: JAEGER
    config:
      service_name: "thanos"
      agent_host: "$(HOST_IP)"
      agent_port: 14250

@matej-g
Copy link
Collaborator

matej-g commented Jun 7, 2022

Awesome! So we actually have this already? Then we can close this issue unless @carlosjgp has further comments.

@matej-g
Copy link
Collaborator

matej-g commented Jun 8, 2022

Closing this as it truly seems this is already implemented, thanks @saswatamcode 👍

@matej-g matej-g closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants