From cdbab0a9824701b3760fffbe2a5ac818cfa1c88d Mon Sep 17 00:00:00 2001 From: Filip Petkovski Date: Fri, 17 Jun 2022 08:06:00 +0200 Subject: [PATCH] Fix tests Signed-off-by: Filip Petkovski --- pkg/receive/handler.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/pkg/receive/handler.go b/pkg/receive/handler.go index 8d59771bfc..d0ebc3e83a 100644 --- a/pkg/receive/handler.go +++ b/pkg/receive/handler.go @@ -115,6 +115,11 @@ func NewHandler(logger log.Logger, o *Options) *Handler { logger = log.NewNopLogger() } + var registerer prometheus.Registerer = nil + if o.Registry != nil { + registerer = o.Registry + } + h := &Handler{ logger: logger, writer: o.Writer, @@ -128,19 +133,19 @@ func NewHandler(logger log.Logger, o *Options) *Handler { Max: 30 * time.Second, Jitter: true, }, - forwardRequests: promauto.With(o.Registry).NewCounterVec( + forwardRequests: promauto.With(registerer).NewCounterVec( prometheus.CounterOpts{ Name: "thanos_receive_forward_requests_total", Help: "The number of forward requests.", }, []string{"result"}, ), - replications: promauto.With(o.Registry).NewCounterVec( + replications: promauto.With(registerer).NewCounterVec( prometheus.CounterOpts{ Name: "thanos_receive_replications_total", Help: "The number of replication operations done by the receiver. The success of replication is fulfilled when a quorum is met.", }, []string{"result"}, ), - replicationFactor: promauto.With(o.Registry).NewGauge( + replicationFactor: promauto.With(registerer).NewGauge( prometheus.GaugeOpts{ Name: "thanos_receive_replication_factor", Help: "The number of times to replicate incoming write requests.",