From 03775c2d325bdd902f1b57f3d9cd50237a7f019f Mon Sep 17 00:00:00 2001 From: Matej Gera <38492574+matej-g@users.noreply.github.com> Date: Mon, 13 Jun 2022 13:26:47 +0200 Subject: [PATCH] Ruler: Change default evaluation interval to 1m (#5417) * Change default eval interval to 1m Signed-off-by: Matej Gera * Update CHANGELOG Signed-off-by: Matej Gera --- CHANGELOG.md | 1 + cmd/thanos/rule.go | 2 +- docs/components/rule.md | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b14a61df1f..1922781b40 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re ### Changed - [#5410](https://github.com/thanos-io/thanos/pull/5410) Query: Close() after using query. This should reduce bumps in memory allocations. +- [#5417](https://github.com/thanos-io/thanos/pull/5417) Ruler: Change default evaluation interval to 1 minute. ### Removed diff --git a/cmd/thanos/rule.go b/cmd/thanos/rule.go index cec7c66022..f1f788e5c7 100644 --- a/cmd/thanos/rule.go +++ b/cmd/thanos/rule.go @@ -125,7 +125,7 @@ func registerRule(app *extkingpin.App) { cmd.Flag("resend-delay", "Minimum amount of time to wait before resending an alert to Alertmanager."). Default("1m").DurationVar(&conf.resendDelay) cmd.Flag("eval-interval", "The default evaluation interval to use."). - Default("30s").DurationVar(&conf.evalInterval) + Default("1m").DurationVar(&conf.evalInterval) conf.rwConfig = extflag.RegisterPathOrContent(cmd, "remote-write.config", "YAML config for the remote-write configurations, that specify servers where samples should be sent to (see https://prometheus.io/docs/prometheus/latest/configuration/configuration/#remote_write). This automatically enables stateless mode for ruler and no series will be stored in the ruler's TSDB. If an empty config (or file) is provided, the flag is ignored and ruler is run with its own TSDB.", extflag.WithEnvSubstitution()) diff --git a/docs/components/rule.md b/docs/components/rule.md index 5c2f81f8fe..1cabaca15c 100644 --- a/docs/components/rule.md +++ b/docs/components/rule.md @@ -310,7 +310,7 @@ Flags: record's value. The URL path is used as a prefix for the regular Alertmanager API path. --data-dir="data/" data directory - --eval-interval=30s The default evaluation interval to use. + --eval-interval=1m The default evaluation interval to use. --grpc-address="0.0.0.0:10901" Listen ip:port address for gRPC endpoints (StoreAPI). Make sure this address is routable