Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SSO for ArgoCD #27

Open
wiardvanrij opened this issue May 30, 2022 · 1 comment
Open

Implement SSO for ArgoCD #27

wiardvanrij opened this issue May 30, 2022 · 1 comment

Comments

@wiardvanrij
Copy link
Member

The current implementation for ArgoCD is that we set the Admin role as default, but since it's only accessible via a port-forward (needing k8s access), this is safe.

We need to go to a situation where:

  • ArgoCD is public accessible, giving READ access to everyone
  • Using SSO to login for Thanos maintainers for admin rights

This means that first we must have: #25 in order to do the SSO callback.
Next:

  • Start with setting the default role to reader
  • Add ingress
  • Implement SSO via Github Thanosio organisation so that maintainers can get admin rights
@Biswajit-Behera
Copy link

Hi @wiardvanrij
Can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants