Added new bench target 'bench-fast' #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Player256 <dattucodes@gmail.com>
mhoffm-aiven
reviewed
Aug 1, 2023
| @@ -101,6 +102,10 @@ func BenchmarkSingleQuery(b *testing.B) { | |||
| } | |||
|
|
|||
| func BenchmarkRangeQuery(b *testing.B) { | |||
There was a problem hiding this comment.
can we just use tesitng.Short() for this?
Signed-off-by: Player256 <dattucodes@gmail.com>
|
yes |
Signed-off-by: Player256 <dattucodes@gmail.com>
Signed-off-by: Player256 <dattucodes@gmail.com>
|
Does it actually work though; the big datasets are still constructed before the benchmark, right? Ill give it a go during EU afternoon. |
hey should I put if statements using testing.short() around the larger dataset. |
that will hide the identifier probably; but i think it can be structured nicer somewhat; We could factor out the slow benchmarks and skip those completely if we have a "Short" flag. |
|
Agree, we should avoid creating the large datasets altogether if |
|
We could add |
I was thinking like this : |
|
@mhoffm-aiven @fpetkovski any thoughts on this? |
|
I would prefer if we group them under "b.Run("fast", ...)" and "b.Run("slow", ...)" and only construct the necessary datasets for the given run |
* CPU time consumed by each operator Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Time consumed by operator when calling Next the TimingOperator struct wraps another VectorOperator and includes a startTime field to track the start time of each Next method call. Inside the Next method implementation of TimingOperator, it captures the current time using time.Now() and stores it in the startTime field. Then, it calls the Next method of the wrapped operator. Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Generalise timing operator for scalar and aggregate Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Added recordTime and duration field in numberLiteralSelector added a boolean flag recordTime to enable or disable recording of time taken.If it is enabled, then I have added the code to record the time taken to the duration field. Also modified the constantMetric to include a new label called . Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * embedding instead of wrapping operator inside of operator The changes are done for capturing observability information for operators in a clean and modular way. By using embedding instead of wrapping, it allows for more granular data capture without creating cross-references between operators. Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Added Analyze method in ExplainableQuery interface The Analyze method returns an AnalyzeOutputNode, which represents the analysis of the query execution. This analysis can include performance metrics, such as CPU time, memory usage, or other relevant statistics. The Analyze method allows for capturing observability information during query execution to assess performance Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Added analyze function for local testing Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Include ObservableVectorOperator in building the operator tree Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Minor changes for type assertion Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Type casting into model.ObservableVectorOperator Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Initialised TimingInformation to avoid nil case Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Next call when Analyze query Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Fixed some checks failing Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Embed struct Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Test code for Query Analyze Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Embed model.OperatorTelemetry Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Assertion function for non-zero CPU Time Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Adding model.OperatorTelemetry to each operator Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Capturing CPUTime of each operator Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * engine: actually execute the query Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Find time consumed by each operator Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Removed unnecessary type casting Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Added analyze function for local testing Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Initialised TimingInformation to avoid nil case Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Next call when Analyze query Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Adding model.OperatorTelemetry to each operator Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Capturing CPUTime of each operator Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Find time consumed by each operator Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Removed unnecessary type casting Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Fixed few minor nits Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Added model.OperatorTelemetry to noArgFunOperator Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Removing type checks for model.TimingInformation Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Removed type checks Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Removed type checks in TestQueryAnalyze Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Fixed few minors issues Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * modified TestQueryAnalyze to check for child operators Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * linters check passed Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Added operatorTelemetry to each operator Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Changed TimingInformation to TrackedTelemetry for recording other telemetry information Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Remove nil case in slice of operators Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * removing unnecessary typecasts Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Set name of operators Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Removed Explain overheads from AnalyzeOutputNode Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * added setName() method to Analyze Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * fixed engine_test Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Removed name from NoopTelemetry Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> * Rename CPU Time -> Execution time Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * engine: clean up last CPUTime reference Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * execution: rename more fields Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> --------- Signed-off-by: nishchay-veer <nishchayveer19@gmail.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Nishchay Veer <99465982+nishchay-veer@users.noreply.github.com> Co-authored-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
* Propagate warnings through context The engine does not return warnings from storage which causes problems with partial response detection in Thanos. I initially thought we had to change the interface of each operator, but @MichaHoffmann had a neat idea to propagate warnings through the context since they have no impact on flow control. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Fix lint Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Replace fmt.Errorf with errors.New Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Use custom type as key Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
This is a follow up commit to thanos-io#298 which enables propagating warnings from remote engines into the distributed query context. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Player256 <dattucodes@gmail.com>
|
Why is the dco check failing even though I had signed off in the commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #292
Added a bool flag
-fast.