Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bench-fast make target which excludes long-running benchmarks #292

Open
fpetkovski opened this issue Jul 7, 2023 · 7 comments
Open
Labels
good first issue Good for newcomers

Comments

@fpetkovski
Copy link
Collaborator

During local development I often rely on the benchmarks to know whether changes I make are going in the right direction.

We currently have some very slow ones so I usually comment those out, but that creates issues when switching branches and I sometimes even commit the commented out code to my branch.

It would be nice to have a bench-fast make target that only runs six hour dataset benchmarks so that we can get faster feedback.

@fpetkovski fpetkovski added the good first issue Good for newcomers label Jul 7, 2023
@Freedisch
Copy link

hi @fpetkovski I would like to work on this issue to start being familiar with the project

@fpetkovski
Copy link
Collaborator Author

Feel free to start on it 👍

@prash240303
Copy link

Hey @fpetkovski , I've been trying to understand the codebase. Can you please assign me this issue so I can work on this ?

@fpetkovski
Copy link
Collaborator Author

Please see above comment.

@Player256
Copy link

@fpetkovski would you give the pr a look?

@sadath-12
Copy link

/assign

@MichaHoffmann
Copy link
Contributor

/assign

Just notice that they are currently commented out; but having the target doesnt hurt i suppose!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants