Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support query maxSamples limit #147

Open
yeya24 opened this issue Jan 12, 2023 · 1 comment
Open

Support query maxSamples limit #147

yeya24 opened this issue Jan 12, 2023 · 1 comment

Comments

@yeya24
Copy link
Contributor

yeya24 commented Jan 12, 2023

The original promql engine supports specifying maxSamples for each query https://github.com/prometheus/prometheus/blob/main/promql/engine.go#L248 and this is useful to protect the query engine from OOM kill.

It would be nice to support this feature here.
@yeya24 yeya24 changed the title Support query maxSamples Support query maxSamples limit Jan 28, 2023
@fatsheep9146
Copy link
Contributor

I'd love to help with this issue.

My idea is that since each operator take a VectorPool to store the temporary results. I think we can cumulate the sample counter when operator store the result into the vector pool.

How do you think about this? @yeya24 @fpetkovski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fatsheep9146 @yeya24