New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query execution observability #106
Comments
What do you think about adding a new option for a query such as |
I think Explain is meant to be used for printing out the plan, but it should be possible to extend it. We can also surface the information through a different method, like Profile: https://github.com/thanos-community/promql-engine/blob/main/engine/engine.go#L181 |
Hello, I would like to work on this as a LFx Mentorship Project. I have some experience in Golang. I am looking to get more information and resources about Thanos project and this issue, to prepare for LFx Mentorship. |
hey @yeya24 @GiedriusS @fpetkovski i would like to contribute to this during lfx mentorship period. I have been working on implementing functions in prom-ql engine in thanos. And, i would like to gain more experience and guidance in my open source journey. I'm looking forward to working with you guys. |
Please apply on the LFX website 🤗 |
We have a link for this now: https://mentorship.lfx.linuxfoundation.org/project/a0958ddf-1fd6-4c8e-887f-adb28639a9f4 🙂 |
Hi @GiedriusS @yeya24 @fpetkovski , I am interested in learning about this project and want to work on this project under LFX Mentorship. Additionally, I was wondering if there is anything else I can do to get started, such as research and learn about the project from the existing documentation. |
@ConnectBhawna you can try compiling and running Thanos locally as per instructions on https://thanos.io/tip/thanos/getting-started.md/. Then, you can try switching to this engine with |
Helloooo!LFX mentorship brought me here..crossing fingers for great contribution experience. |
Hello @GiedriusS @yeya24 @fpetkovski, Please let me know, of any resources or materials I need to know to understand the project better and help me get started. I have submitted the application for LFX mentorship! |
FYI according to #thanos-dev slack, @PradyumnaKrishna got the mentorship from LFX to work on this project. Thank you all for the interest 🙏 |
In my opinion, there are two ways of going around this: embedding observability information into each operator that implements |
@saswatamcode Are the applications open for LFX mentorship Term 2 ? |
Hello, @GiedriusS, @saswatamcode, I am interested in learning about this project and want to work on this project under LFX Mentorship. |
Hey @yeya24 @GiedriusS |
One thing I feel quite limited is the query logger from the original promql engine. It would be great to have observabilities for the queries being executed through the engine and we can see each queries duration, the query plan, detailed stats, etc.
Some more features could be also nice and I am not sure whether it is in scope of this project. Things like slow queries, top queries, etc. That's usually built in in some relational databases and it would be really powerful to collect those query stats like https://docs.pingcap.com/tidb/dev/top-sql.
The text was updated successfully, but these errors were encountered: