Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the objstore operation duration metrics are 0 #56

Open
harry671003 opened this issue Jun 13, 2023 · 2 comments
Open

Some of the objstore operation duration metrics are 0 #56

harry671003 opened this issue Jun 13, 2023 · 2 comments

Comments

@harry671003
Copy link

The InstrumentedBucket doesn't emit duration metrics for Iter().

thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="0.001"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="0.01"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="0.1"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="0.3"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="0.6"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="1"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="3"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="6"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="9"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="20"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="30"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="60"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="90"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="120"} 0
thanos_objstore_bucket_operation_duration_seconds_bucket{bucket="",component="compactor",operation="iter",le="+Inf"} 0
thanos_objstore_bucket_operation_duration_seconds_sum{bucket="",component="compactor",operation="iter"} 0
thanos_objstore_bucket_operation_duration_seconds_count{bucket="",component="compactor",operation="iter"} 0

https://github.com/thanos-io/objstore/blob/main/objstore.go#L487
Is this by design? I would like to measure the time taken for iterating the bucket.

@ritaCanavarro
Copy link
Contributor

Hi @harry671003, I would like to pick up this subject. Can you assign it to me?

@gotjosh
Copy link
Contributor

gotjosh commented Sep 26, 2023

Sorry @ritaCanavarro, I didn't see this issue - I have filed #79 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants