Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate modules for metrics and tracing wrappers #2

Open
brancz opened this issue Mar 24, 2022 · 5 comments
Open

Add separate modules for metrics and tracing wrappers #2

brancz opened this issue Mar 24, 2022 · 5 comments
Assignees

Comments

@brancz
Copy link
Member

brancz commented Mar 24, 2022

The specific libraries and mechanisms used for metrics and tracing can be quite opinionated and a library meant as an abstraction for object storage providers should not force a dependency of one or the other system onto downstream users. As such I think that the:

  • prometheus wrapper (already exists)
  • opentracing wrapper (already exists)
  • opentelemetry wrapper (does not exist yet)

Should be served by separate modules.

@kakkoyun kakkoyun self-assigned this Jul 8, 2022
@bwplotka
Copy link
Member

bwplotka commented Jul 13, 2022

Agree, there is a simpler idea, though: Just abstract away the metrics and opentracing as much as possible - but maybe overkill.

@bboreham
Copy link

OpenTracing has been deprecated for nearly a year; why wouldn't you just switch to OpenTelemetry?
Adding abstractions over abstractions seems like an antipattern to me.

There is a bridge for anyone who needs OpenTracing.

@brancz
Copy link
Member Author

brancz commented Oct 26, 2022

I agree I wouldn’t want yet another abstraction, but for me it was important people choose to adopt the dependency, not us force it onto people.

@bboreham
Copy link

Maybe if you include "no dependency" as an option that becomes clearer?
I.e. the abstraction would include a no-op tracer.

@brancz
Copy link
Member Author

brancz commented Nov 9, 2022

I'm not exactly sure what you're proposing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants