Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Make CI tests work against essential buckets (S3, GCS, Swift, Azure) #10

Open
kakkoyun opened this issue Jul 11, 2022 · 1 comment
Open

chore: Make CI tests work against essential buckets (S3, GCS, Swift, Azure) #10

kakkoyun opened this issue Jul 11, 2022 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@kakkoyun
Copy link
Member

objstore/.github/workflows/test.yaml

Lines 79 to 84 in 4963440

# TODO(kakkoyun): Make this work with GCS,S3,SWIFT!
run: |-
if [ -z ${GCP_PROJECT} ]; then
export THANOS_TEST_OBJSTORE_SKIP=${THANOS_TEST_OBJSTORE_SKIP},GCS,S3
fi
echo "Skipping tests for object storages: ${THANOS_TEST_OBJSTORE_SKIP}"

@kakkoyun kakkoyun added the help wanted Extra attention is needed label Jul 11, 2022
@kakkoyun kakkoyun changed the title chore: Make CI tests work against essential buckets (S3, GCS, SWift) chore: Make CI tests work against essential buckets (S3, GCS, Swift) Jul 13, 2022
@bwplotka
Copy link
Member

Still to do 🤗

@bwplotka bwplotka changed the title chore: Make CI tests work against essential buckets (S3, GCS, Swift) chore: Make CI tests work against essential buckets (S3, GCS, Swift, Azure) Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kakkoyun @bwplotka