Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support full stack in kustomization.yaml #215

Open
cten opened this issue Mar 25, 2021 · 2 comments
Open

Support full stack in kustomization.yaml #215

cten opened this issue Mar 25, 2021 · 2 comments

Comments

@cten
Copy link

cten commented Mar 25, 2021

The current kustomization.yaml file doesn't support all the components of the Thanos stack. Can it be updated to use the manifests from the examples/all-manifests folder or can we add a kustomization.yaml file to the that folder?
Would be happy to create a PR if it can be decided where the best location is.
Thanks

@metalmatze
Copy link
Member

The manifests folder is supposed to be a small but functional example of a Thanos stack that can be applied and should work.
The files in examples/all/manifests is literally enabling all available configuration options to be able to better track the output of our jsonnet stack over time. I'm certain that the outputs from that folder will not work - and won't even make sense to be applied as they are.

We can for sure update the kustomization.yaml to support everything from manifests/ 👍

@cten
Copy link
Author

cten commented Mar 26, 2021

Can you tell me if the file names in examples/all/manifests change often? Do the resource names declared in the manifests change often?
Final question: can you give guidance on the different sharding options available in the jsonnet config (1 Statefulset or 3 almost identical Statefulsets)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants