Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "SnoreToast" label from the notifications #810

Closed
araujoarthur0 opened this issue Nov 1, 2021 · 2 comments · Fixed by #837
Closed

Remove "SnoreToast" label from the notifications #810

araujoarthur0 opened this issue Nov 1, 2021 · 2 comments · Fixed by #837
Labels
enhancement New feature or request help wanted Extra attention is needed windows Issues specific on Windows

Comments

@araujoarthur0
Copy link
Collaborator

Describe the current limitation
The notifications are coming with a SnoreToast label on Windows. On the notifications tab they're also grouped under that name. They should instead have a Time to Leave label.

image

Apparently we need to change some sort of AppId to fix that: https://github.com/mikaelbr/node-notifier

@araujoarthur0 araujoarthur0 added enhancement New feature or request help wanted Extra attention is needed windows Issues specific on Windows labels Nov 1, 2021
@ghost
Copy link

ghost commented Nov 5, 2021

There's more info on this problem here: mikaelbr/node-notifier/issues/332

After a first glance at that thread, it seems like an "appID" property might need to be added to the notifier.notify object in /js/notification.js

However, the string used for that property apparently "must be exactly the same value that was registered during the installation of your app". Not entirely sure what this means, but after a little digging I found that the "AppUserModelID" for time-to-leave is "com.squirrel.time_to_leave.time-to-leave".

So, based on that, it seems like the "correct" string that Windows is looking for as an appID would be "time-to-leave". I tried adding that as a property, but I'm unfamiliar with this app (and electron apps in general), and not sure what the easiest way is to trigger a notification? Is there an easy dev flag or something where I can just throw out a notification for testing purposes?

I won't have an opportunity to work on this for a couple days, but if nobody has submitted a solution by then I'd be happy to look further into this.

@araujoarthur0
Copy link
Collaborator Author

Thanks @iamrichR !

what the easiest way is to trigger a notification? Is there an easy dev flag or something where I can just throw out a notification for testing purposes?

You can use the notification test:
Run "npm run test:jest notification" on the command line and it should trigger some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed windows Issues specific on Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant